feat: add --hash flag to CLI commands #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a --hash/-H flag to the CLI commands to support specifying the underlying hash algorithm to use for IDs. Currently only SHA-256 is supposed, but the OmniBOR spec is designed to handle future changes to add other algorithms (for example, if SHA-256 is later broken and collisions become possible to generate). It also mildly improves help text for the CLI. Signed-off-by: Andrew Lilley Brinker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a --hash/-H flag to the CLI commands to support
specifying the underlying hash algorithm to use for IDs. Currently
only SHA-256 is supposed, but the OmniBOR spec is designed to handle
future changes to add other algorithms (for example, if SHA-256
is later broken and collisions become possible to generate).
It also mildly improves help text for the CLI.
Signed-off-by: Andrew Lilley Brinker [email protected]